Nested switch structures are difficult to understand because you can easily confuse the cases of an inner switch as
belonging to an outer statement. Therefore nested switch statements should be avoided.
Specifically, you should structure your code to avoid the need for nested switch statements, but if you cannot, then consider moving
the inner switch to another function.
Noncompliant code example
public function func(foo:Number, bar:Number):void
{
switch (foo)
{
case 1:
// do something
break;
case 2:
switch (bar) // Noncompliant
{
case 89: // It's easy to lose sight of what's being tested; is it foo or bar?
// ...
break;
case 90:
// ...
break;
}
break;
case 3:
// do something
break;
default:
break;
}
}
Compliant solution
public function func(foo:Number, bar:Number):void
{
switch (foo)
{
case 1:
// ...
break;
case 2:
handleBar(bar);
break;
case 3:
// ...
break;
default:
break;
}
}
public function handleBar(bar:Number):void
{
switch (bar)
{
case 89:
// ...
break;
case 90:
// ...
break;
}
}
